Jump to content

P4V tosses changes

P4 submit shelved dataloss

  • Please log in to reply
1 reply to this topic

#1 RTMerkel



  • Members
  • Pip
  • 1 posts
  • LocationIntel, Folsom, CA

Posted 17 March 2014 - 05:40 PM


I work for Intel (Folsom, CA) and we use P4V. Consider the following:

1. Randy shelved and reverted all of his changes for a very important change™.
2. Latter, Randy tries to submit said change-list...
3. P4V says “can’t submit because of shelved changes, delete?” Yes – note that this happens about 99% of the time, so this is muscle memory, i.e., most users don’t even read the dialog anymore!
4. P4V says “Can’t submit because the change list is empty” Randy: screaming!!!

This has happened multiple times in my group to multiple engineers... and yes, these are pretty smart people.

I'd like to suggest the following change: do not allow a submit if it's bound to fail, say because there are no unshelved files in the change list. Either make the submit impossible, say by graying out the menu item, or by the following:

Submit (change-list N)
    if (N has not unshelved files) fail!
    else if (N has unshelved files, but all are unchanged and don't submit unchanged files option is set) fail!
    else proceed...

#2 P4Matt


    Advanced Member

  • Members
  • PipPipPip
  • 1383 posts

Posted 17 March 2014 - 08:41 PM

I full heartedly agree that change, or something very similar, needs to be made. I've filed a bug report and discussed it with the V lead; we take data loss issues very seriously.

If this is an epidemic you could put a server trigger in place on shelve-delete to block the accidental delete. I'd be happy to provide an example trigger.

Also tagged with one or more of these keywords: P4, submit, shelved, dataloss

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users