Jump to content


Review Emails Not Sent

reviews email

  • Please log in to reply
6 replies to this topic

#1 Jason C

Jason C

    Newbie

  • Members
  • Pip
  • 3 posts

Posted 07 May 2014 - 02:07 PM

I have an Ubuntu server running p4d.
The server can send emails (using Postfix)
I have added the path of a chunk of the depot in the Reviews section using Connecton | Edit Current User.
I can confirm the reviews using p4 reviews

But no emails are sent when I submit changes that touch files within scope and I don't see any errors or otherwise in the log.

Have I missed a step?

#2 P4Matt

P4Matt

    Advanced Member

  • Members
  • PipPipPip
  • 1383 posts

Posted 07 May 2014 - 04:48 PM

To have reviews sent out you'll also need to setup a review script to generate and fire off the messages. My current favorite was written by one of our support folks:

https://swarm.worksh...cheung-p4review

Here's the installation readme:
https://swarm.worksh...iew2.readme.txt

Here's the script itself:
https://swarm.worksh...in/p4review2.py

#3 Jason C

Jason C

    Newbie

  • Members
  • Pip
  • 3 posts

Posted 07 May 2014 - 07:54 PM

Thanks, Matt!

#4 Lennart Kjellén

Lennart Kjellén

    Advanced Member

  • Members
  • PipPipPip
  • 30 posts
  • LocationSweden

Posted 08 May 2014 - 05:40 AM

The review feature is well integrated in both documentation and appropriate client software. It is reasonable to expect also sending of emails to be integrated in server software. Why is it designed so that you need a separate script for this?

#5 P4Matt

P4Matt

    Advanced Member

  • Members
  • PipPipPip
  • 1383 posts

Posted 08 May 2014 - 04:51 PM

When Perforce was first written many moons ago (1995!) portability was one of its number one goals. My understanding is there was enough variability in email handling across OSs that it was decided it made more sense to make it easy to get the review information and then push the actual email server interaction out to something that could be easily modified for any platform.

For people using Swarm, our collaboration tool, review email is entirely handled by that application, including activity notification.

#6 Jason C

Jason C

    Newbie

  • Members
  • Pip
  • 3 posts

Posted 09 May 2014 - 09:39 AM

I am probably being dumb, but what is likely the cause of this?

2014-05-09 10:19 INFO	 App (pid=10771) initiated.
2014-05-09 10:19 INFO	 Review counter (review): 258
2014-05-09 10:19 INFO	 Scraping for change review...
2014-05-09 10:19 INFO	 1 change review(s).
2014-05-09 10:19 INFO	 0 job review(s).
2014-05-09 10:19 CRITICAL <type 'exceptions.TypeError'>
2014-05-09 10:19 CRITICAL character mapping must return integer, None or unicode
2014-05-09 10:19 CRITICAL   File "p4review2.py", line 1284, in <module>
	rv = app.run()
2014-05-09 10:19 CRITICAL   File "p4review2.py", line 1213, in run
	self.send_one_email_per_change()

(feel free to bump me to another thread/topic)

#7 P4Lester

P4Lester

    Advanced Member

  • Members
  • PipPipPip
  • 144 posts

Posted 22 May 2014 - 11:52 PM

Let me guess - are using Python 3.x? You will need Python 2.7.

I need to update the script so that it works with Python3 at some point....

Email support@perforce.com and put my name in the email if you need someone to troubleshoot this further for you.

I work for Perforce.
Workshop | Twitter | LinkedIn | about.me






Also tagged with one or more of these keywords: reviews, email

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users