Jump to content

Testing changes between review cycles


  • Please log in to reply
1 reply to this topic

#1 briand


    Advanced Member

  • Members
  • PipPipPip
  • 77 posts

Posted 26 August 2014 - 10:26 PM

From time to time, we have engineers that want to test their changes in multiple workspaces before submitting them for second (or third) review cycle. Before Swarm, they would just re-shelve their changes in the current changelist and unshelve them in another workspace. But, with Swarm, as soon as they shelve their test changes (those that are not yet ready for another review pass) to allow them to test with a different workspace, Swarm automatically starts up another review pass (causing people to review changes that are not yet ready for a review and frustrating everyone involved).

The only way we've discovered around this problem, so far, is to move the files out of the changelist that is attached to the Swarm review, shelve the changes as necessary for testing (knowing that Swarm knows nothing about this new changelist), then move them back into the original changelist that Swarm knows about and shelve them yet again to update the review.

Is there an easier process?

#2 P4PetrH


    Advanced Member

  • Members
  • PipPipPip
  • 36 posts

Posted 27 August 2014 - 04:29 PM

That is what I usually do. Prior to 2014.3 release, you could edit the changelist description to replace #review-123 with something like #_review-123 to make it not recognized as a review keyword pattern, and then shelving it would not update review-123. This approach doesn't work any more (i.e. in 2014.3) as Swarm remembers changes that have been once associated to a review and will always update the review when files in these changes are shelved or committed.

Also tagged with one or more of these keywords: swarm

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users