Jump to content


Automatically closing reviews when committed?

review close committed

  • Please log in to reply
1 reply to this topic

#1 Andrew DeFaria

Andrew DeFaria

    Advanced Member

  • Members
  • PipPipPip
  • 125 posts

Posted 23 January 2015 - 09:32 PM

If I understand correctly, from Swarm's Review queue screen there are two tabs - Opened and Closed. You can filter things so show approved reviews and some will show on the Opened tab and some on the Closed tab. AFAICT reviews are "closed" if approved and committed. Swarm has both Approve and Commit and Already Committed actions.

So the review author is shouldered with the responsibility of selecting one of those two actions. What I'm wondering about is why can't Swarm be triggered to "close" any reviews when the changes are submitted or committed to the repository?

#2 PeteS

PeteS

    Advanced Member

  • Members
  • PipPipPip
  • 62 posts

Posted 23 January 2015 - 09:38 PM

Interesting idea, but I would not like that personally.

If someone asked for a review on a shelved file, I wouldn't want it marked as approved just because they got tired of waiting for approval and submitted the change!

What I would like however, is the ability to "Approve Already Committed Change", rather than have to do "Already Committed" then Approve - essentially making it a single atomic operation. Essentially the equivalent of "Approve and Commit" but after the fact.



Also tagged with one or more of these keywords: review, close, committed

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users