2 replies to this topic

[jerome]

Hi, we are evaluating swarm 2014.4/988814 and are seeing delays in email notifications. We haven't really noticed any pattern, sometimes the emails are sent within a few minutes, sometimes few hours.

For example, one developer makes a review comment at 12:21, the notification was received at 16:45 !
EDIT: it seems that our mail server is sometimes holding some of swarm mails. Anyway, in this example, swarm apparently waited about 19 minutes before sending the notification which is rather strange.

For the context, we never had any issue with our email server. Our swarm server is configured with three workers {"tasks":0,"futureTasks":0,"workers":3,"maxWorkers":3,"workerLifetime":"595s"} and we are using the OVA distribution (2014/3/958056 apt-get upgraded). The main swarm features are working fine, no noticeable delays in browsing code, creating reviews...etc.

Note that our logs contain several lines of the following error, which is odd because we did not customize the email template:
2015-02-10T01:19:51+00:00 ERR (3): Cannot send mail. No valid templates specified.

Our email configuration is:
  

'notifications' => array(
	 'opt_in_review_path' => '//swarm',
	 'disable_change_emails' => true,
	 'honor_p4_reviews' => false,
),

Any idea ?

[PeteS]

FWIW, I'm investigating some complaints of users not receiving Swarm alerts, and I see the same "Cannot send mail" error in my logs, but it only seems to apply to one review.

Here's the rest of the call stack:

2015-02-11T11:29:53-08:00 ERR (3): exception 'P4\Connection\Exception\CommandException' with message
'Command failed: // - must refer to client '~tmp.1423682882.7985.54dbad420d9d82.39251944'.' in /opt/perforce/swarm/library/P4/Connection/AbstractConnection.php:1056

Stack trace:
#0 /opt/perforce/swarm/library/P4/Connection/AbstractConnection.php(750): P4\Connection\AbstractConnection->handleError(Object(P4\Connection\CommandResult))
#1 /opt/perforce/swarm/module/Changes/Module.php(245): P4\Connection\AbstractConnection->run('reviews', Array)
#2 [internal function]: Changes\{closure}(Object(Zend\EventManager\Event))
#3 /opt/perforce/swarm/library/Zend/EventManager/EventManager.php(468): call_user_func(Object(Closure), Object(Zend\EventManager\Event))
#4 /opt/perforce/swarm/library/Zend/EventManager/EventManager.php(207): Zend\EventManager\EventManager->triggerListeners('task.commit', Object(Zend\EventManager\Event), NULL)
#5 /opt/perforce/swarm/module/Queue/src/Queue/Controller/IndexController.php(179): Zend\EventManager\EventManager->trigger(Object(Zend\EventManager\Event))
#6 /opt/perforce/swarm/library/Zend/Mvc/Controller/AbstractActionController.php(83): Queue\Controller\IndexController->workerAction()
#7 [internal function]: Zend\Mvc\Controller\AbstractActionController->onDispatch(Object(Zend\Mvc\MvcEvent))
#8 /opt/perforce/swarm/library/Zend/EventManager/EventManager.php(468): call_user_func(Array, Object(Zend\Mvc\MvcEvent))
#9 /opt/perforce/swarm/library/Zend/EventManager/EventManager.php(207): Zend\EventManager\EventManager->triggerListeners('dispatch', Object(Zend\Mvc\MvcEvent), Object(Closure))
#10 /opt/perforce/swarm/library/Zend/Mvc/Controller/AbstractController.php(117): Zend\EventManager\EventManager->trigger('dispatch', Object(Zend\Mvc\MvcEvent), Object(Closure))
#11 /opt/perforce/swarm/library/Zend/Mvc/DispatchListener.php(114): Zend\Mvc\Controller\AbstractController->dispatch(Object(Zend\Http\PhpEnvironment\Request), Object(Zend\Http\PhpEnvironment\Response))
#12 [internal function]: Zend\Mvc\DispatchListener->onDispatch(Object(Zend\Mvc\MvcEvent))
#13 /opt/perforce/swarm/library/Zend/EventManager/EventManager.php(468): call_user_func(Array, Object(Zend\Mvc\MvcEvent))
#14 /opt/perforce/swarm/library/Zend/EventManager/EventManager.php(207): Zend\EventManager\EventManager->triggerListeners('dispatch', Object(Zend\Mvc\MvcEvent), Object(Closure))
#15 /opt/perforce/swarm/library/Zend/Mvc/Application.php(309): Zend\EventManager\EventManager->trigger('dispatch', Object(Zend\Mvc\MvcEvent), Object(Closure))
#16 /opt/perforce/swarm/public/index.php(57): Zend\Mvc\Application->run()
#17 {main}
2015-02-11T11:29:53-08:00 ERR (3): Cannot send mail. No valid templates specified.

[Matt Janulewicz]

I just ran into the same thing and found that if you set "disable_change_emails" to false, or don't set it at all, it works.

I filed a bug report with Perforce support for this a few minutes ago.