Jump to content

Alternate workflow for pre-commit code review request ?


  • Please log in to reply
1 reply to this topic

#1 jerome



  • Members
  • PipPip
  • 10 posts

Posted 10 February 2015 - 02:05 PM

Hi, there is something bothering us and we are wondering if this is expected and if this can cause us some issues...

We understand the pre-commit code review workflow with the review keyword / shelving however we noticed that we can access any changelist through swarm with http://swarm/changes/#.

This inevitably brought us to this situation: one developer accessed his pending changelist with shelved files through http://swarm/changes/# and then requested a code review on it.

It seems to work fine but we don't have that #review-123 updated in the concerned changelist description. Is that a valid workflow ?

#2 briand


    Advanced Member

  • Members
  • PipPipPip
  • 77 posts

Posted 12 February 2015 - 11:31 PM

Having the ability to request a review through Swarm allows a person other than the author to request a review. Unfortunately, as you noticed, this method does not update the description. I remember some configuration lines that seemed to point to a future ability to insert the #review keyword into a description that does not have it. I have no guess on when/if this functionality will get implemented.

Also tagged with one or more of these keywords: swarm

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users