Jump to content


DVCS and SWARM

dvcs swarm

  • Please log in to reply
8 replies to this topic

#1 Kei Son

Kei Son

    Advanced Member

  • Members
  • PipPipPip
  • 46 posts

Posted 19 May 2015 - 10:30 PM

I'm evaluating the feature DVCS from 2015.1 with the perforce swarm as a part of our work process.

Is there any chance I can shelve a changelist into the shared-server to make new review at the perforce swarm? And a way to make a review from submitted changelist on my local-server?

#2 P4Shimada

P4Shimada

    Advanced Member

  • Members
  • PipPipPip
  • 831 posts

Posted 21 May 2015 - 10:06 PM

Hello Kei Son,

Yes, you can use a shelved changelist to make a review with Swarm. For example, you can view a shelved changelist, click the 'Request Review' button to request a review of that shelved change. See here on how to start a code review:

http://www.perforce....ode_review.html

I hope this helps to answer your question.  :-)


REFERENCES

- Review Workflow
http://www.perforce....s.workflow.html

- How do I contribute comments or code changes to a code review?
http://www.perforce....contribute.html

#3 Kei Son

Kei Son

    Advanced Member

  • Members
  • PipPipPip
  • 46 posts

Posted 21 May 2015 - 10:16 PM

We already use the perforce swarm for review stage of our workflow. However, in the world of DVCS, I can shelve and submit into my local server and cannot shelve into a shared server for triggering swarm script to review, but only push. Right? So that meanings that I can make post-commit review only instead of pre-commit.

#4 Mailman Sync

Mailman Sync

    Advanced Member

  • Maillist Aggregator
  • 2495 posts

Posted 30 July 2015 - 12:20 PM

Originally posted to the perforce-user mailing list by: Lester Cheung


Hi Kei,

Quote

We already use the perforce swarm for review stage of our workflow. However, in
the world of DVCS, I can shelve and submit into my local server and cannot
shelve into a shared server for triggering swarm script to review, but only
push. Right? So that meanings that I can make post-commit review only instead of
pre-commit.

Correct. Currently it’s not possible to shelve files to the central server from a DVCS repo.


@p4lester | http://about.me/lestercheung
_______________________________________________
perforce-user mailing list  -  perforce-user@perforce.com
http://maillist.perf...o/perforce-user



#5 mcru

mcru

    Advanced Member

  • Members
  • PipPipPip
  • 63 posts

Posted 18 September 2017 - 03:11 PM

I have the same question now in 2017... any chance it is now possible to perform pre-commit code review with perforce dvcs and swarm?

#6 Sambwise

Sambwise

    Advanced Member

  • Members
  • PipPipPip
  • 894 posts

Posted 18 September 2017 - 03:47 PM

Skimming through the Swarm relnotes:

https://www.perforce...rm_relnotes.txt

it doesn't look like any DVCS functionality has been added to Swarm.

I do note that the graph depot is fully supported in p4d 17.1:

https://www.perforce...er/relnotes.txt

which represents an alternative (Git-based) DVCS solution.

#7 P4Sven

P4Sven

    Advanced Member

  • Staff
  • 32 posts
  • LocationWokingham, UK

Posted 18 September 2017 - 04:10 PM

I think your best bet is to use a development branch in the master depot, push your changes into it and then create a review from there.

You can push shelves from DVCS now, but it is not very useful for a review.

Cheers,

Sven Erik

--

Sven Erik Knop | Principal Solutions Engineer
Perforce Software<http://www.perforce.com>
T: +44 1189 771020<tel:+441189771020> | M: +44 7974 351514<tel:+447974351514>
Visit us on: Twitter<https://twitter.com/perforce> | LinkedIn<https://www.linkedin...force-software> | Facebook<https://www.facebook.com/Perforce>

New code hosting for Git, SVN, and more.
Try Helix TeamHub free today!<http://info.perforce...signature-link>



On 18 Sep 2017, at 16:50, Sambwise <perforce-user-forum@forums.perforce.com<mailto:perforce-user-forum@forums.perforce.com>> wrote:

Posted on behalf of forum user 'Sambwise'.

Skimming through the Swarm relnotes:

https://www.perforce...rm_relnotes.txt

it doesn't look like any DVCS functionality has been added to Swarm.

I do note that the graph depot is fully supported in p4d 17.1:

https://www.perforce...er/relnotes.txt

which represents an alternative (Git-based) DVCS solution.



--
Please click here to see the post in its original format:
http://forums.perfor...-dvcs-and-swarm
_______________________________________________
perforce-user mailing list  -  perforce-user@perforce.com
http://maillist.perf...o/perforce-user

_______________________________________________
perforce-user mailing list  -  perforce-user@perforce.com
http://maillist.perf...o/perforce-user


#8 mcru

mcru

    Advanced Member

  • Members
  • PipPipPip
  • 63 posts

Posted 18 September 2017 - 05:20 PM

Quote

You can push shelves from DVCS now, but it is not very useful for a review.

Sven, can I ask why this is? I had planned on opening these pushed shelved CLs for review in swarm.

#9 P4Sven

P4Sven

    Advanced Member

  • Staff
  • 32 posts
  • LocationWokingham, UK

Posted 18 September 2017 - 05:55 PM

This should work (I haven't tested this myself), you just have to add #review to the description

Maybe you can do the following:

Link the master main code line to your local MAIN via the remote
Branch MAIN into a dev stream and work there
Update MAIN from remote
Merge your changes from dev into MAIN and shelve them - and then push the shelve

This is a workflow some of us are using here. Might need some tweaking on merge down/copy up, but since it is your DVCS you can do whatever you want with that.


Cheers,

Sven Erik

--

Sven Erik Knop | Principal Solutions Engineer
Perforce Software<http://www.perforce.com>
T: +44 1189 771020<tel:+441189771020> | M: +44 7974 351514<tel:+447974351514>
Visit us on: Twitter<https://twitter.com/perforce> | LinkedIn<https://www.linkedin...force-software> | Facebook<https://www.facebook.com/Perforce>

New code hosting for Git, SVN, and more.
Try Helix TeamHub free today!<http://info.perforce...signature-link>



On 18 Sep 2017, at 18:25, mcru <perforce-user-forum@forums.perforce.com<mailto:perforce-user-forum@forums.perforce.com>> wrote:

Posted on behalf of forum user 'mcru'.



Quote
You can push shelves from DVCS now, but it is not very useful for a review.
Sven, can I ask why this is? I had planned on opening these pushed shelved CLs
for review in swarm.



--
Please click here to see the post in its original format:
http://forums.perfor...-dvcs-and-swarm
_______________________________________________
perforce-user mailing list  -  perforce-user@perforce.com<mailto:perforce-user@perforce.com>
http://maillist.perf...o/perforce-user

_______________________________________________
perforce-user mailing list  -  perforce-user@perforce.com
http://maillist.perf...o/perforce-user






Also tagged with one or more of these keywords: dvcs, swarm

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users