Jump to content


Perforce Settings Dialog Appearing Every Time Game is Stopped in Unity Editor with P4Connect 2016.1.137.5274 (Apr 7 2016)


  • Please log in to reply
4 replies to this topic

#1 rtande

rtande

    Member

  • Members
  • PipPip
  • 19 posts
  • LocationBay Area, California

Posted 21 April 2016 - 11:19 PM

Our team has just upgraded to P4Connect 2016.1.137.5274 (Apr 7 2016) from the workshop and performance is definitely better. However, a number of us on Windows (not OSX) have found that the P4Connect settings dialog appears every time we stop the game running in Unity.

We have a workaround which is to dock the P4Connect settings dialog so that it's always on-screen. This workaround is ok but there are a couple of issues

1) If you dock it as a tab with another tab e.g. the console window, it becomes impossible to switch to the other window while the game is running in the Unity editor
2) In some circumstances exceptions are raised from the P4Connect settings dialog (unfortunately I don't have a copy of the exceptions)

Rajan

#2 rtande

rtande

    Member

  • Members
  • PipPip
  • 19 posts
  • LocationBay Area, California

Posted 22 April 2016 - 12:16 AM

The exceptions appear when you start Unity with the P4Connect Settings dialog docked

There are two exceptions

The first one is

NullReferenceException: Object reference not set to an instance of an object
UnityEngine.GUILayoutUtility.DoGetRect (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayoutUtility.cs:332)
UnityEngine.GUILayoutUtility.GetRect (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayoutUtility.cs:323)
UnityEngine.GUILayout.DoButton (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayout.cs:53)
UnityEngine.GUILayout.Button (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayout.cs:51)
P4Connect.Config.OnGuiStatusBar ()
P4Connect.Config.OnGUI ()
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)


And the second is


ArgumentException: Getting control 2's position in a group with only 2 controls when doing Repaint
Aborting
UnityEngine.GUILayoutGroup.GetNext () (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayoutUtility.cs:656)
UnityEngine.GUILayoutUtility.DoGetRect (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayoutUtility.cs:363)
UnityEngine.GUILayoutUtility.GetRect (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayoutUtility.cs:323)
UnityEngine.GUILayout.DoButton (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayout.cs:53)
UnityEngine.GUILayout.Button (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayout.cs:51)
P4Connect.Config.OnGuiStatusBar ()
P4Connect.Config.OnGUI ()
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)


There are about 10 of these exceptions raised but the plug-in continues to work fine

#3 Chris Brooks

Chris Brooks

    Newbie

  • Members
  • Pip
  • 2 posts

Posted 25 April 2016 - 10:58 PM

We experienced the same thing, and it made this release unusable. :(

#4 P4Norman

P4Norman

    Advanced Member

  • Staff
  • 81 posts
  • LocationOakland CA, USA

Posted 12 May 2016 - 06:21 PM

Fixed in the 2016.2 release available here:  https://swarm.worksh...t/main/releases

Thank you for reporting this to us.

#5 rtande

rtande

    Member

  • Members
  • PipPip
  • 19 posts
  • LocationBay Area, California

Posted 13 May 2016 - 06:03 PM

Hi Norman,

We upgraded to this yesterday and I'm very pleased to say that this bug is fixed and this version of P4Connect seems to be much more reliably checking out files. Thanks for your work on this.

One slight wrinkle is that if you had the P4Connect Settings dialog box docked in Unity, then you need to undock and close the window BEFORE you upgrade, otherwise you are left with an empty window which can't be closed without resetting your Unity editor window layout.




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users