Jump to content


How to add additional pending changelists to pre-commit code review?

swarm changelist

  • Please log in to reply
1 reply to this topic

#1 mcru

mcru

    Advanced Member

  • Members
  • PipPipPip
  • 50 posts

Posted 09 August 2017 - 10:26 PM

If you have a review for a pending changelist for pre-commit code review, how can you add additional commits to that review?

Is the only option to add files to and update files in that pending changelist? Can you not append additional commits to a review with #review-<review_id> like you can for post-commit code review?

#2 mcru

mcru

    Advanced Member

  • Members
  • PipPipPip
  • 50 posts

Posted 09 August 2017 - 10:52 PM

Nevermind, it looks like you actually can just add a new pending changelist by adding #review-<review_id> to your shelve description. I had biffed the commands so it just wasn't appending properly.

One additional question - if I try to update the pending CL for the review, I get a message saying "Change #### belongs to client swarm-some-hash-to-be-unique-to-swarm-and-review.". How can I update this pending changelist? Or, is that bad practice, and I should be appending additional pending CL's to a review in order to merge my change w/ latest so it can be committed?



Also tagged with one or more of these keywords: swarm, changelist

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users